Uploaded image for project: 'Planet4'
  1. Planet4
  2. PLANET-5615

Use button tags for buttons

XMLWordPrintable

      Currently a lot of our buttons use anchor tags, that's not good in terms of accessibility, and also causes issues when trying to disable them. We should use <button> tags instead.

      From a quick search it seems that all of our primary buttons are anchors, and also our "Donate" button, but maybe there are more.

      Update: we discussed this issue a bit more within the P4 team and actually it's not the best to convert all of our anchor tags into buttons… That would mean that we need to implement in JS the href, opening in new tabs etc and I didn't really think it through when creating the ticket. From a quick accessibility search (https://a11y-101.com/design/button-vs-link), the problem is more that we make links look like buttons, which is something our design team would need to work on before we can make changes.


      Copied on Github

            contributor Community Contributor
            mleray Maud Leray
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: