-
Task
-
Resolution: Duplicate
-
Should have
-
None
-
None
-
Campaigns
As a follow up from workweeks discussion:
- Explore option to not include style when import/export to another site, user would need to assign the style afterwards
- Explore if customiser styles conflicts with child theme
- Consider saas refactoring by split component overrides in theme files:
The theme files are getting quite long (~600 lines) and we are using delimiter comments for sections (see: https://github.com/greenpeace/planet4-plugin-gutenberg-blocks/blob/develop/assets/src/styles/campaigns/themes/_theme_oceans.scss#L196 ), this probably means we could separate those blocks from the main file, leaving only the global definitions in the root file and using includes like "_theme_oil_covers", "_theme_oil_spreadsheet" and so on.
It's just an idea, some refactors will surely emerge from the work week, feel free to dismiss if it doesn't make sense anymore.
- Check at work currently done in
PLANET-5114andPLANET-5104and investigate changes needed for campaigns in NROs sites using child themes - Meet with NROs (Stefan, Dirk, Oscar) to discuss (gather feedback in next dev's community call)
- Breakdown tickets needed for follow up
See Pieter's comment here:
- duplicates
-
PLANET-5104 Add css variables for common child theme overrides
- CLOSED
- is cloned by
-
PLANET-4742 Allow option to disable styles of campaign pages
- CLOSED
- is duplicated by
-
PLANET-4694 Investigate: Sass refactor - split component overrides in theme files
- CLOSED
- relates to
-
PLANET-4604 #409951: CPP importer: xml import does not work well
- CLOSED