Uploaded image for project: 'Planet4'
  1. Planet4
  2. PLANET-3641

Implement a more strict ESLint config to achieve consistency

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Should have Should have
    • None
    • 3
    • Testing
    • Sprint #138, Sprint #139, Sprint #140, Sprint #198, Sprint #199, Sprint #200, Sprint #201, Sprint #202, Sprint #203, Sprint #204, Sprint #205
    • janus

      Review the ESLint config and see if it can be made stricter (eg. adding whitespace rules), to ensure code gets more consistent. Our current config was configured before we started adding React to the frontend, so it may require some additional work. 

      Tasks

      • Determine if this requires an ADR first. If so follow the steps described below and defer the rest of the tasks to a follow-up implementation ticket.
      • Adjust CI config to lint all js code (currently only checks public/*.js)
      • Adjust our blocks js code to meet current eslint configuration. If it turns out to be too many code changes per block, create subtasks.
      • Adjust eslint config to be more strict to enforce the rules we already apply

      ADR Tasks (if needed)

      • Refine the ADR to reach a "proposed" status.
      • Request for comments on the dev channel.
      • Address or integrate comments where applicable.
      • Bring the ADR for discussion in the next Refinment session.
      • Open implementation tickets once ADR has reached "decided" status.

            oagbernd Osong Agberndifor
            mleray Maud Leray
            Maud Leray Maud Leray
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: