Uploaded image for project: 'Planet4'
  1. Planet4
  2. PLANET-1858

Cookies Policy reappears every time on ios devices

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Should have Should have
    • 1.9.0
    • 4
    • Homepage
    • Sprint #31

      Currently the cookie policy pop up that opens when you first open the site reappears every time if you use Safari or Chrome in iOs. (Tested by Kelli and Luca).

      The cookie named "greenpeace" has no set expiration date, effectively expiring on session. This causes different beheaviour in different devices (as described also at: https://stackoverflow.com/questions/4132095/when-does-a-cookie-with-expiration-time-at-end-of-session-expire )

      We need to change the expiration of that cookie, to "never". (In reality, a date far away in the future, like 1 year).

      Two things:

      In custom.js

      https://github.com/greenpeace/planet4-master-theme/blob/master/assets/js/custom.js#L183-L185

      the function we are using right now "createCookie" disregards its own "days" parameter.

      First task is to fix this function to take into account its own days parameter

      Second task is to change the line

      https://github.com/greenpeace/planet4-master-theme/blob/master/assets/js/custom.js#L207

      createCookie('greenpeace', 'policy-accepted');
      

      To include the number of days.

       

            asingh Ashish Singh
            kkokkoro Konstantinos Kokkorogiannis
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: