Uploaded image for project: 'Planet4'
  1. Planet4
  2. PLANET-6197

Twitter embed doesn't fit in the page on mobile width

    XporterXMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Should have
    • Resolution: Merged
    • Affects Version/s: None
    • Fix Version/s: 2.58.2
    • Labels:
    • Story Points:
      2
    • Section:
      Block: Social Media
    • Track:
      Development
    • P4 Test Environment:
      umbriel
    • Repositories:
      planet4-master-theme, planet4-plugin-gutenberg-blocks

      Description

      Twitter embed in a post doesn't fit in a mobile width, probably because of a fixed 500px rule in our css https://github.com/greenpeace/planet4-master-theme/blob/90c9c38419475cf51b5023bd3195ac816487e1cb/assets/src/scss/pages/post/_article-content.scss#L255.

      Instagram embeds should follow the same rule, but it is overloaded by a different one in https://github.com/greenpeace/planet4-plugin-gutenberg-blocks/blob/a42c46cfa5b01f335d73e599595f139b9c3359e4/assets/src/styles/blocks/Media.scss#L92

      Tasks

      • Check if the faulty rule is used/applied elsewhere
      • Remove it, test twitter and instagram embeds with various page widths to ensure it fits in the page

       

        Gliffy Diagrams

          Attachments

            Activity

              People

              Assignee:
              fhernand Florent Hernandez
              Reporter:
              fhernand Florent Hernandez
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: